update and refine the fully converged design after team discussion#249
Open
liunick-msft wants to merge 6 commits intomainfrom
Open
update and refine the fully converged design after team discussion#249liunick-msft wants to merge 6 commits intomainfrom
liunick-msft wants to merge 6 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Azure Local ToR networking documentation to recommend a simplified Fully Converged storage VLAN design (one storage VLAN per ToR), and aligns reference/configuration guidance and troubleshooting steps with that approach.
Changes:
- Replaced “both storage VLANs on both ToRs” guidance with a “one storage VLAN per ToR (recommended)” baseline and clarified failover behavior.
- Updated NX-OS sample configuration snippets (allowed VLAN lists / VLAN definitions) and updated FAQs to match the revised pattern.
- Updated Environment Validator troubleshooting guidance to reflect the revised VLAN-to-ToR mapping.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| TSG/Networking/Top-Of-Rack-Switch/Reference-TOR-Fully-Converged-Storage.md | Updates key design principle, FAQs, and switch config examples for the new fully converged storage VLAN recommendation. |
| TSG/Networking/Top-Of-Rack-Switch/Overview-Azure-Local-Deployment-Pattern.md | Updates deployment pattern overview/FAQ language and tables to reflect the recommended per-ToR storage VLAN mapping. |
| TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-StorageConnections-ConnectivityCheck.md | Adjusts troubleshooting guidance for converged storage connectivity checks to align with the recommended VLAN placement. |
TSG/Networking/Top-Of-Rack-Switch/Reference-TOR-Fully-Converged-Storage.md
Show resolved
Hide resolved
TSG/Networking/Top-Of-Rack-Switch/Reference-TOR-Fully-Converged-Storage.md
Outdated
Show resolved
Hide resolved
TSG/Networking/Top-Of-Rack-Switch/Overview-Azure-Local-Deployment-Pattern.md
Outdated
Show resolved
Hide resolved
TSG/Networking/Top-Of-Rack-Switch/Overview-Azure-Local-Deployment-Pattern.md
Outdated
Show resolved
Hide resolved
...onmentValidator/Networking/Troubleshoot-Network-Test-StorageConnections-ConnectivityCheck.md
Show resolved
Hide resolved
Collaborator
|
@liunick-msft It looks like you didn't address the copilot review yet. Once that's done I'll review as well. |
Contributor
|
@liunick-msft I've opened a new pull request, #262, to work on those changes. Once the pull request is ready, I'll request review from you. |
…gn update (#262) * Initial plan * Remove VLAN 712 from ToR1 configuration block (one storage VLAN per ToR) Co-authored-by: liunick-msft <105009141+liunick-msft@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: liunick-msft <105009141+liunick-msft@users.noreply.github.com>
Contributor
|
@liunick-msft I've opened a new pull request, #263, to work on those changes. Once the pull request is ready, I'll request review from you. |
…erence doc (#263) * Initial plan * Unify all TOR switch naming to TOR-A and TOR-B in Reference-TOR-Fully-Converged-Storage.md Co-authored-by: liunick-msft <105009141+liunick-msft@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: liunick-msft <105009141+liunick-msft@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
@liunick-msft I've opened a new pull request, #264, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates Azure Local documentation to recommend a simplified and more efficient storage VLAN configuration for Fully Converged deployments. The new guidance recommends mapping one storage VLAN per ToR switch (rather than both VLANs on both switches), clarifies failover behavior, and updates diagrams, tables, FAQs, and configuration examples accordingly. The changes aim to improve clarity, reduce configuration complexity, and reflect current best practices.
Documentation and Configuration Guidance Updates: